[Top] [All Lists]

Re: [PATCH] XFS: Don't flush stale inodes

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: Don't flush stale inodes
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 2 Jan 2010 07:00:53 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1262399980-19277-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1262399980-19277-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Jan 02, 2010 at 01:39:40PM +1100, Dave Chinner wrote:
> Because inodes remain in cache much longer than inode buffers do
> under memory pressure, we can get the situation where we have stale,
> dirty inodes being reclaimed but the backing storage has been freed.
> Hence we should never, ever flush XFS_ISTALE inodes to disk as
> there is no guarantee that the backing buffer is in cache and
> still marked stale when the flush occurs.

We should not flush stale inodes.  But how do we even end up calling
xfs_iflush with a stale inode?

<Prev in Thread] Current Thread [Next in Thread>