[Top] [All Lists]

Re: [PATCH] XFS: Kill filestreams cache flush

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: Kill filestreams cache flush
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 2 Jan 2010 06:53:38 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1262399900-19110-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1262399900-19110-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Jan 02, 2010 at 01:38:20PM +1100, Dave Chinner wrote:
> The filestreams cache flush is not needed in the sync code as it
> does not affect data writeback, and it is now not used by the
> growfs code, either, so kill it.

I have to admit I never understood the purpose of this call.

What xfs_fstrm_free_func does is:

 - clear the filesystems flag on the inode
 - decrement pagf_fstrms
 - drop references on the inode (and parent if known)
 - free the filestream item

Nothing of that should matter for sync, although dropping inode
references during sync might generally be a good idea.

<Prev in Thread] Current Thread [Next in Thread>