xfs
[Top] [All Lists]

Re: [PATCH] improve xfsinvutil man page and argument processing

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH] improve xfsinvutil man page and argument processing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 10:57:13 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20091223152057.GA21306@xxxxxxx>
References: <4B300507.1070502@xxxxxxx> <20091223133321.GA10982@xxxxxxxxxxxxx> <20091223152057.GA21306@xxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Dec 23, 2009 at 09:20:59AM -0600, Bill Kendall wrote:
> Reposting to fix whitespace issues introduced by mailer.

The patch looks good and applies cleanly now,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Some notes to look into after this patch:

 - can you provide a testcase for the problems caused by the wrong
   time_t usage?  A patch to xfstests would be perfect, but if you
   have a raw testcase I'll vounteer to wire it up.
 - why do we wrap both ctime and ctime_r?  Currently xfsdump isn't
   multithreaded so we shouldn't need it.  But if the parallel
   dump/restore ever gets merged from IRIX we need to get rid of the
   plain ctime calls.  (Btw, are there any plans for the parallel
   dump/restore port?)

<Prev in Thread] Current Thread [Next in Thread>