xfs
[Top] [All Lists]

Re: [PATCH] use time32_t consistently in xfsdump tree

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH] use time32_t consistently in xfsdump tree
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 08:31:36 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4B300389.7020905@xxxxxxx>
References: <4B300389.7020905@xxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Dec 21, 2009 at 05:23:53PM -0600, Bill Kendall wrote:
> xfsdump stores time_t as 32-bits in its dump and inventory
> structures for portability/historical reasons. xfsinvutil
> uses time_t directly, leading to some strange results on
> systems which have a 64-bit time_t.
>
> The 32-bit time-related functions were factored out into
> their own file since they are now used by xfsinvutil, and
> their original file (util.c) could not easily be linked
> with xfsinvutil due to dependencies on many other
> dump/restore modules.

The newly created timeutil.[ch] did not get included into the patch,
so I can't easily review them, and the rest of the patch also seems
whitespace mangled to me.

The changes in it looks good, just the time_t to time32_t conversions
plus overflow checks.

<Prev in Thread] Current Thread [Next in Thread>