xfs
[Top] [All Lists]

Re: [PATCH 1/2] add lpath_to_handle to libhandle

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH 1/2] add lpath_to_handle to libhandle
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 23 Dec 2009 08:15:35 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <4B300B2F.7080305@xxxxxxx>
References: <4AE08DC7.7000200@xxxxxxx> <20091024133904.GB23125@xxxxxxxxxxxxx> <4B300B2F.7080305@xxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
> Based on Christoph's suggestion here's a rework of the patch
> (that I've been sitting on for a while). This requires no change
> to the libhandle API and no changes in xfsdump (and hence just
> this one patch. The previously posted patch 2/2 is dropped).

The patch looks good for me from review, but fails to apply probably due
to whitespace damage in the mailer.

One thing that could be changes is to also do the fspath conversion for
block and chacater special files.  While we can open those they will not
end up in the xfs file operations and thus not provide the nessecary
ioctl.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>


Btw, it would be nice if you could write a testcase for xfstests that
fails with the old version on links but works with the new one.

<Prev in Thread] Current Thread [Next in Thread>