xfs
[Top] [All Lists]

Re: [fuse-devel] utimensat fails to update ctime

To: OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
Subject: Re: [fuse-devel] utimensat fails to update ctime
From: Jean-Pierre André <jean-pierre.andre@xxxxxxxxxx>
Date: Tue, 22 Dec 2009 13:07:22 +0100
Cc: Eric Blake <ebb9@xxxxxxx>, fuse-devel@xxxxxxxxxxxxxxxxxxxxx, Miklos Szeredi <miklos@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <874onjjnln.fsf@xxxxxxxxxxxxxxxxxxx>
References: <4B2B156D.9040604@xxxxxxx> <87aaxclr4q.fsf@xxxxxxxxxxxxxxxxxxx> <4B2F7421.10005@xxxxxxx> <4B2F7A95.3010708@xxxxxxx> <87hbrkjrk8.fsf@xxxxxxxxxxxxxxxxxxx> <4B304D04.6040501@xxxxxxx> <87d427jscr.fsf@xxxxxxxxxxxxxxxxxxx> <4B3097C4.3060803@xxxxxxxxxx> <874onjjnln.fsf@xxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4) Gecko/20091027 Fedora/2.0-7.fc13 SeaMonkey/2.0
Hi again,

OGAWA Hirofumi wrote:
Jean-Pierre André<jean-pierre.andre@xxxxxxxxxx>  writes:

Hi all,
Hi,

OGAWA Hirofumi wrote:
Eric Blake<ebb9@xxxxxxx>   writes:


It is likely the issue of libfuse or ntfs-3g. I don't know about ntfs-3g
people at all. So, for now, just Cc: to fuse people.

Which ntfs-3g version are you using ?
I don't know which version is used by actual user. But, well, I've got
source by "apt-get source", and the version was 1:2009.4.4-1.
Now, I've got ntfs-3g-2009.11.14AC.2.tgz from specified url.

utimensat(0, NULL, {UTIME_OMIT, UTIME_NOW}, 0) = 0
Currently ntfs-3g does not set sub-second precision.

There is also a slight problem in the fuse interface :
the time buffer is never passed as NULL, consequently
in some circumstances ntfs-3g cannot decide correctly
over permissions. A permissive action is taken in this
situation.

 From this, "ia_valid" will have "ATTR_CTIME | ATTR_MTIME". And the
request would pass to userland via fuse of kernel part, then it will be
handled by libfuse.

 From quick grep of libfuse and ntfs-3g (would not be latest), ntfs-3g is
using "struct fuse_operations", not "struct fuse_lowlevel_ops".

With the latest ntfs-3g, currently as a release candidate,
you can (optionally) use the low level fuse interface
http://pagesperso-orange.fr/b.andre/advanced-ntfs-3g.html
use the "lowntfs-3g" driver instead of "ntfs-3g"
Well, the problem seems in fuse_lib_setattr() and ntfs_fuse_setattr()
(lowlevel op too).

The both functions is requiring "ATIME | MTIME". Doesn't it mean the
ntfs-3g can't set only MTIME like above utimensat()?

With ntfs-3g this is not directly possible, because
the interface does not provide flags telling which
timestamps should be updated. The only way would
be fuse feeding both values (even though unchanged)
before calling ntfs-3g. This is true for all versions of
ntfs-3g.

With lowntfs-3g (release candidate only), this could
be possible.... but this is not implemented, as the
case was never found up to now. I can provide you
with a patch,... if fuse can feed in the flags selectively.

In fuse_lib_setattr(),

         if (!err&&  (valid&  (FUSE_SET_ATTR_ATIME | FUSE_SET_ATTR_MTIME)) ==
             (FUSE_SET_ATTR_ATIME | FUSE_SET_ATTR_MTIME)) {

In ntfs_fuse_setattr(),
        case FUSE_SET_ATTR_ATIME + FUSE_SET_ATTR_MTIME :
                res = ntfs_fuse_utime(&security, ino, attr,&stbuf);

Or I'm missing something?

Thanks.

Regards

Jean-Pierre



<Prev in Thread] Current Thread [Next in Thread>