[Top] [All Lists]

Re: [PATCHv2 00/12]posix_acl: Add the check items

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCHv2 00/12]posix_acl: Add the check items
From: liu weni <qingshenlwy@xxxxxxxxx>
Date: Mon, 21 Dec 2009 22:15:26 +0800
Cc: chris.mason@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, joel.becker@xxxxxxxxxx, cjb@xxxxxxxxxx, jmorris@xxxxxxxxx, serue@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, adilger@xxxxxxx, jack@xxxxxxx, tytso@xxxxxxx, dwmw2@xxxxxxxxxxxxxxxxxxxx, swhiteho@xxxxxxxxxx, bfields@xxxxxxxxxxxx, neilb@xxxxxxx, ffilzlnx@xxxxxxxxxx, bharrosh@xxxxxxxxxxx, mfasheh@xxxxxxxx, tiger.yang@xxxxxxxxxx, jeffm@xxxxxxxx, aelder@xxxxxxx, sandeen@xxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, strongzgy@xxxxxxxxx, onlyflyer@xxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=+95LbBgcUirYbsZqUo57OJGJ9MRE1nDbAWj3igL/psk=; b=kikXixIU+xEmVKJ4qYVLu/nXxuFfLIR7bLl0G/Wrxm/GopC12FviRU2HqAGLciQNui 8grlAqyhLtSBgiAgu3auyc5eWnBPBD9almHt+vRuSICAUTMrGeXjA6ZVHyUTaDiGVcCb 2fJrjTKi+YTckbtpeRb+eZkxiWQDHdE8vA/tY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=Z9/BrETwy/JaS1cnbu3pbc5TzIi6uEJacv+MkA3EtYTrsdzj1B6tb2BTqw6lrmju6d xZo+h1xiPA31N0S+d6aWeGmcZjq/dUamuFX1yWtB65UzslZ0hF/G3Ldic2Tds+TGcl0F MW0w9ST+swh7jphTVXniE1j6tqfHThxtY3HsA=
In-reply-to: <20091221123654.GA9201@xxxxxx>
References: <4B2F6153.8010609@xxxxxxxxx> <20091221123654.GA9201@xxxxxx>
Thanks for your suggestion.

In my opinion the null point is a incorrect state for the acl, then I
return -EINVAL.

I will check this state transition in XFS.

2009/12/21 Christoph Hellwig <hch@xxxxxx>:
> I like taking these checks into posix_acl_valid, but I think the patch
> submission needs a bit more work.
> All the patches are extremly whitespace mangled.  And I don't think
> splitting them up makes a whole lot of sense, when we do API changes
> like this we usually fix up all callers.  So please try to fix your
> mailer, merged them all into one, and maybe also chose a more
> descriptive subject line, e.g.
> Subject: take checks for NULL and error pointers into posix_acl_valid()
> And btw, at least the XFS change seems incorrect - previously we
> returned NULL acl pointer and this patch changes it to -EINVAL.

<Prev in Thread] Current Thread [Next in Thread>