xfs
[Top] [All Lists]

Re: [PATCH] xfs_fsr: don't create ag temp subdirs with mode 0777

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_fsr: don't create ag temp subdirs with mode 0777
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Dec 2009 04:08:54 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4B2073D1.1040809@xxxxxxxxxxx>
References: <4B2073D1.1040809@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Dec 09, 2009 at 10:06:41PM -0600, Eric Sandeen wrote:
> This addresses Debian bug #559490 - xfsdump: fsr creates files mode 666
> 
> I think that this mode is left over from when xfs_fsr used to
> fork into the uid of the file's owner, and so needed somewhere
> it was guaranteed to be able to write.
> 
> This behavior was removed in commit d51b892411c8d33374a02e20c5888df280811549
> (in the xfsdump tree, before xfs_fsr got moved) and so these
> wide-open permissions should no longer be needed.

Looks good to me,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>