[Top] [All Lists]

[PATCH] xfs_fsr: don't create ag temp subdirs with mode 0777

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfs_fsr: don't create ag temp subdirs with mode 0777
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 09 Dec 2009 22:06:41 -0600
User-agent: Thunderbird (Macintosh/20090812)
This addresses Debian bug #559490 - xfsdump: fsr creates files mode 666

I think that this mode is left over from when xfs_fsr used to
fork into the uid of the file's owner, and so needed somewhere
it was guaranteed to be able to write.

This behavior was removed in commit d51b892411c8d33374a02e20c5888df280811549
(in the xfsdump tree, before xfs_fsr got moved) and so these
wide-open permissions should no longer be needed.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
Reviewed-by: Nathan Scott <nscott@xxxxxxxxxx>

(Note: I already got a review from Nathan, so barring any complaint
I'll push this to the xfsprogs-dev tree soon.)

diff --git a/fsr/xfs_fsr.c b/fsr/xfs_fsr.c
index 253a55d..21f08c3 100644
--- a/fsr/xfs_fsr.c
+++ b/fsr/xfs_fsr.c
@@ -1541,7 +1541,7 @@ tmp_init(char *mnt)
        for (i=0; i < fsgeom.agcount; i++) {
                sprintf(buf, "%s/.fsr/ag%d", mnt, i);
-               if (mkdir(buf, 0777) < 0) {
+               if (mkdir(buf, 0700) < 0) {
                        if (errno == EEXIST) {
                                if (dflag)

<Prev in Thread] Current Thread [Next in Thread>