xfs
[Top] [All Lists]

Re: [PATCH] db: stop using xfs_bmbt_rec_32_t

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] db: stop using xfs_bmbt_rec_32_t
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 4 Dec 2009 05:04:01 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4B16A5E8.8070604@xxxxxxxxxxx>
References: <20091103155019.GA28991@xxxxxxxxxxxxx> <4B16A5E8.8070604@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Dec 02, 2009 at 11:37:44AM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > xfs_db uses the xfs_bmbt_rec_32_t type to pass around extent information in 
> > a
> > few places.  But everywhere where we actually use it we use the normal
> > xfs_bmbt_rec_t just casting from/to xfs_bmbt_rec_32_t to pass it around.
> > 
> > Just pass the xfs_bmbt_rec_t directly and thus get rid of the last use
> > of xfs_bmbt_rec_32_t in xfsprogs.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Seems fine.
> 
> After this should the db references to xfs_bmbt_rec_64_t be
> changed to xfs_bmbt_rec_t perhaps?

Yes, except that we don't actually have the struct type for it yet which
we'll need in at least one place.  I'll do it once I've removed the _32
and _64 types in the kernel and synced over the changes to userspace.

<Prev in Thread] Current Thread [Next in Thread>