xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: enable missing functions

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_io: enable missing functions
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 3 Dec 2009 12:00:59 -0500
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4B16AE64.5080700@xxxxxxxxxxx>
References: <4B16AE64.5080700@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Dec 02, 2009 at 12:13:56PM -0600, Eric Sandeen wrote:
> madvise and mincore were never hooked up to init_commands().
> 
> Further, there is no HAVE_INJECT test in the configure scripts,
> so just remove that test (and keep the existing unconditional
> inject_init() prototype.

Hmm, maybe Nathan still has an idea what it's for, probably some IRIX
build.

Anyway, the madvise and mincore wireup looks good.  Note entirely sure
what they do in xfs_io, though - they're VM syscalls not filesystem and
don't cause I/O normally.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>