xfs
[Top] [All Lists]

Re: [PATCH] xfstests 213: Add enospc case to fallocate test

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfstests 213: Add enospc case to fallocate test
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Wed, 25 Nov 2009 15:36:10 -0600
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20091125210731.GB12150@xxxxxxxxxxxxx>
References: <4B0D66F7.5080704@xxxxxxxxxx> <20091125210731.GB12150@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Christoph Hellwig wrote:
> On Wed, Nov 25, 2009 at 11:18:47AM -0600, Eric Sandeen wrote:
>> Add a test for ENOSPC when fallocating.
>>
>> Also, add an expected output, not sure how that went missing!
> 
> Oops.  Easily to do because xfstests doesn't complain but rather just
> skips tests without golden output..
> 
> I guess the ENOSPC test is to catch the inverted error returns just
> detected?

yep

> Anyway, looks good,

thanks!

-eric

> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>