xfs
[Top] [All Lists]

Re: XFS support for ARMv5

To: Ofer Heifetz <oferh@xxxxxxxxxxx>
Subject: Re: XFS support for ARMv5
From: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
Date: Sun, 22 Nov 2009 08:45:01 -0800
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=pfWKQwZR+MrWg5F6VEtaTZ6SGMNSAd/SXmAE7kl7SFw=; b=Rk54Kro7MT0tkqUz+twVeeCXns+/vTKIYy9uEy8PI5x+HCu0LkHRB2HbaAx0/OnJLJ aWh9FGWQU0WkbXnvhrXyBVbg0aeaKqhV9zGqSRXCNQO6ODY+hd5I5bl8+pV1xsfEaxxF PIDAjirnWSU3Khfvhs5n3MgjUQMRPusw+iyKc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=DBnEgYZa0dKm7TDt9D6ojJKfb8Gcnp33hxWXMPTItAH+KQv0HNGbh8QlqVo+00zM7M /Rm4piI+KWUbpng98ja3ZKVobbsDPdBEDoXSD8ija5MQLBGOZGzDYRd6rVU1Apwcdodz g5DMYOuYA44rBEPY666pzvFDAYf4Np7ZlD+UA=
In-reply-to: <EE71107DF0D1F24FA2D95041E64AB9E8985A59F17F@xxxxxxxxxxxxxxxxxxx>
References: <14274282.01258546868484.JavaMail.root@wombat> <4B041AEE.4040506@xxxxxxxxxxx> <EE71107DF0D1F24FA2D95041E64AB9E8985A59F17F@xxxxxxxxxxxxxxxxxxx>
On Sun, Nov 22, 2009 at 8:20 AM, Ofer Heifetz <oferh@xxxxxxxxxxx> wrote:
> Hi Eric,
>
> I have tried the patch you advised and still get the same error using 
> 2.6.31.6, xfs version 2.10.2 on Ubuntu 9.04.
>
> Any other suggestions you think that might help me with this?

If it is a Marvell chip, we eventually found that we had to add
flush_icache_range, although we were doing that in our SCSI_LLD.

> -Ofer
>
> -----Original Message-----
> From: Eric Sandeen [mailto:sandeen@xxxxxxxxxxx]
> Sent: Wednesday, November 18, 2009 6:04 PM
> To: Ofer Heifetz
> Cc: xfs@xxxxxxxxxxx
> Subject: Re: XFS support for ARMv5
>
> oferh@xxxxxxxxxxx wrote:
>> Hi,
>>
>> I have noticed that XFS on ARMv5TE with latest kernel (2.6.31.6)
>> fails to mount after copying some data and reboot the system.
>>
>> I get "mount: /dev/sda1: can't read superblock", I understand that
>> there were some problems with virtual aliasing that was added to XFS
>> some time ago but ARM arch has not dealt with this properly.
>
> when you get that error from mount, look at dmesg to see what really went 
> wrong ...
>
>> Is there any patch for this bug?
>
> This is a big-hammer approach for the aliasing problem:
>
> Index: linux-2.6.25-rc1/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- linux-2.6.25-rc1.orig/fs/xfs/linux-2.6/xfs_buf.c
> +++ linux-2.6.25-rc1/fs/xfs/linux-2.6/xfs_buf.c
> @@ -1172,6 +1172,7 @@ _xfs_buf_ioapply(
>                bio->bi_end_io = xfs_buf_bio_end_io;
>                bio->bi_private = bp;
>
> +               flush_dcache_page(bp->b_pages[0]);
>                bio_add_page(bio, bp->b_pages[0], PAGE_CACHE_SIZE, 0);
>                size = 0;
>
> @@ -1198,6 +1199,7 @@ next_chunk:
>                if (nbytes > size)
>                        nbytes = size;
>
> +               flush_dcache_page(bp->b_pages[map_i]);
>                rbytes = bio_add_page(bio, bp->b_pages[map_i], nbytes, offset);
>                if (rbytes < nbytes)
>                        break;
>
>
>
>> xfsprogs version used: 2.10.2
>>
>> -Ofer
>>
>> -- This message was sent on behalf of oferh@xxxxxxxxxxx at
>> openSubscriber.com
>> http://www.opensubscriber.com/messages/xfs@xxxxxxxxxxx/topic.html
>>
>> _______________________________________________ xfs mailing list
>> xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
>>
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
>



-- 
Regards,
Richard Sharpe

<Prev in Thread] Current Thread [Next in Thread>