| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: make several more functions static |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Fri, 20 Nov 2009 09:32:48 -0600 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <20091120063720.GA3804@xxxxxxxxxxxxxxxx> |
| References: | <4B0569A0.10405@xxxxxxxxxxx> <20091120063720.GA3804@xxxxxxxxxxxxxxxx> |
| User-agent: | Thunderbird 2.0.0.23 (Macintosh/20090812) |
Dave Chinner wrote:
> On Thu, Nov 19, 2009 at 09:52:00AM -0600, Eric Sandeen wrote:
>> Just minor housekeeping, a lot more functions can be trivially
>> made static; others could if we reordered things a bit...
>
> Only one minor comment:
>
>> -void
>> +STATIC_INLINE void
>> xlog_put_bp(
>> xfs_buf_t *bp)
>> {
>
> I'd change that as STATIC as Christoph's recent patch removed
> STATIC_INLINE. gcc will inline it for us if it's a win....
Oops, ok, thanks for looking at it.
-Eric
> Cheers,
>
> Dave.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | XFS, NFS and inode64 on 2.6.27, Michael Monnerie |
|---|---|
| Next by Date: | **Check Out**, charlott |
| Previous by Thread: | Re: [PATCH] xfs: make several more functions static, Dave Chinner |
| Next by Thread: | Subscription Verification, Towey Software.co.uk |
| Indexes: | [Date] [Thread] [Top] [All Lists] |