xfs
[Top] [All Lists]

Re: [PATCH] libdisk: do not install libdisk.a

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] libdisk: do not install libdisk.a
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 18 Nov 2009 22:08:15 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091030131517.GB18462@xxxxxxxxxxxxx>
References: <20091030131517.GB18462@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Christoph Hellwig wrote:
> Since xfsprogs 3.0 libdisk is intended to be private to xfsprogs and we do
> not install the headers anymore.  But we kept installing the static library,
> which doesn't make sense.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> 
> Index: xfsprogs-dev/libdisk/Makefile
> ===================================================================
> --- xfsprogs-dev.orig/libdisk/Makefile        2009-10-30 13:12:03.000000000 
> +0000
> +++ xfsprogs-dev/libdisk/Makefile     2009-10-30 13:12:08.000000000 +0000
> @@ -27,6 +27,5 @@ include $(BUILDRULES)
>  install: default
>  
>  install-dev: default
> -     $(INSTALL_LTLIB_STATIC)
>  
>  install-qa: install-dev
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] libdisk: do not install libdisk.a, Eric Sandeen <=