xfs
[Top] [All Lists]

Re: [PATCH] mkfs: add discard support

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH] mkfs: add discard support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 12 Nov 2009 11:04:20 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1157959921.9631254878431584.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <20091007011850.GA32032@xxxxxxxxxxxxx> <1157959921.9631254878431584.JavaMail.root@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
Adding the discard helper to the platform headers now causes the build
to fail for some external users of the xfs headers because off64_t doesn't
exist without the large file configure magic. E.g. for xfstests:

checking xfs/xfs.h usability... no
checking xfs/xfs.h presence... yes
configure: WARNING: xfs/xfs.h: present but cannot be compiled
configure: WARNING: xfs/xfs.h:     check for missing prerequisite headers?
configure: WARNING: xfs/xfs.h: see the Autoconf documentation
configure: WARNING: xfs/xfs.h:     section "Present But Cannot Be Compiled"
configure: WARNING: xfs/xfs.h: proceeding with the compiler's result
checking for xfs/xfs.h... no

commenting out the discard helper fixes this.  We might be able to just
switch to a int64_t or similar instead, even if that's a bit ugly.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] mkfs: add discard support, Christoph Hellwig <=