xfs
[Top] [All Lists]

RE: [PATCH] xfstests: add another quotaoff testcase to 220

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: RE: [PATCH] xfstests: add another quotaoff testcase to 220
From: "Alex Elder" <aelder@xxxxxxx>
Date: Mon, 2 Nov 2009 12:46:33 -0600
Cc: <xfs@xxxxxxxxxxx>
In-reply-to: <20091030093155.GA9329@xxxxxxxxxxxxx>
Thread-index: AcpZR6hwObLW6KXRQo+/xSOHs3aRgwCpNifA
Thread-topic: [PATCH] xfstests: add another quotaoff testcase to 220
Christoph Hellwig wrote:
> Add the quotafile space remove regression test from Ryota Yamauchi to
> testcase 220.

Looks good.  This tests the actual problem reported by Ryota Yamauchi.

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Index: xfstests-dev/220
> ===================================================================
> --- xfstests-dev.orig/220     2009-10-30 09:16:52.000000000 +0000
> +++ xfstests-dev/220  2009-10-30 09:29:19.000000000 +0000
> @@ -1,10 +1,10 @@
>  #! /bin/sh
>  # FS QA Test No. 220
>  #
> -# Test that turning quotas off on a mounted filesystem doesn't crash
> -# the system.
> +# Test quota off handling.
>  #
> -# Based on a bug report from Utako Kusaka <u-kusaka@xxxxxxxxxxxxx>.
> +# Based on bug reports from Utako Kusaka <u-kusaka@xxxxxxxxxxxxx> and
> +# Ryota Yamauchi <r-yamauchi@xxxxxxxxxxxxx>.
>  #
>  #-----------------------------------------------------------------------
>  # Copyright (c) 2009 Christoph Hellwig.  All Rights Reserved.
> @@ -67,5 +67,19 @@ xfs_quota -x -c off $SCRATCH_DEV
>  # and unmount (this used to crash)
>  umount $SCRATCH_DEV
> 
> +
> +# create scratch filesystem
> +_scratch_mkfs_xfs >/dev/null 2>&1
> +
> +# mount  with quotas enabled
> +_scratch_mount -o uquota
> +
> +# turn off quota and remove space allocated to the quota files
> +# (this used to give wrong ENOSYS returns in 2.6.31)
> +xfs_quota -x -c off -c remove $SCRATCH_DEV
> +
> +# and unmount again
> +umount $SCRATCH_DEV
> +
>  status=0
>  exit $status
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>
  • RE: [PATCH] xfstests: add another quotaoff testcase to 220, Alex Elder <=