xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix up have_xlog_assign_lsn config test

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: fix up have_xlog_assign_lsn config test
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 30 Oct 2009 01:43:00 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4ADE80D1.7080408@xxxxxxxxxxx>
References: <4ADE80D1.7080408@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Oct 20, 2009 at 10:32:33PM -0500, Eric Sandeen wrote:
> Without this we weren't building src/loggen

Looks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
> ---
>
> diff --git a/aclocal.m4 b/aclocal.m4
> index 8a61e39..6e1e672 100644
> --- a/aclocal.m4
> +++ b/aclocal.m4
> @@ -422,10 +422,10 @@ AC_DEFUN([AC_PACKAGE_WANT_XFS_LIBXFS_H],
>   ])
>
> AC_DEFUN([AC_PACKAGE_WANT_XLOG_ASSIGN_LSN],
> -  [
> -    AC_CHECK_DECL(xlog_assign_lsn,
> +  [ AC_CHECK_DECL(xlog_assign_lsn,
>       [ have_xlog_assign_lsn=true ], [ have_xlog_assign_lsn=false ],
>       [[#include <xfs/libxfs.h>]])
> +    AC_SUBST(have_xlog_assign_lsn)
>   ])
>
> AC_DEFUN([AC_PACKAGE_NEED_XFS_XQM_H],
> diff --git a/m4/package_xfslibs.m4 b/m4/package_xfslibs.m4
> index 870882f..f5167a2 100644
> --- a/m4/package_xfslibs.m4
> +++ b/m4/package_xfslibs.m4
> @@ -14,11 +14,10 @@ AC_DEFUN([AC_PACKAGE_WANT_LIBXFS_H],
>   ])
>
> AC_DEFUN([AC_PACKAGE_WANT_XLOG_ASSIGN_LSN],
> -  [
> -    AC_CHECK_DECL(xlog_assign_lsn,
> +  [ AC_CHECK_DECL(xlog_assign_lsn,
>       [ have_xlog_assign_lsn=true ], [ have_xlog_assign_lsn=false ],
>       [[#include <xfs/libxfs.h>]])
> -    AC_SUBST(have_have_xlog_assign_lsn)
> +    AC_SUBST(have_xlog_assign_lsn)
>   ])
>
> AC_DEFUN([AC_PACKAGE_NEED_XFS_XQM_H],
>
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>