xfs
[Top] [All Lists]

Re: [PATCH 2/2] use lpath_to_handle when restoring symlinks

To: Bill Kendall <wkendall@xxxxxxx>
Subject: Re: [PATCH 2/2] use lpath_to_handle when restoring symlinks
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 27 Oct 2009 23:34:05 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4AE71364.7090102@xxxxxxx>
References: <4AE08DD0.50304@xxxxxxx> <20091025070544.GA21462@xxxxxxxxxxxxx> <4AE71364.7090102@xxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Oct 27, 2009 at 10:36:04AM -0500, Bill Kendall wrote:
> On 10/25/2009 02:05 AM, Christoph Hellwig wrote:
>> On Thu, Oct 22, 2009 at 11:52:32AM -0500, Bill Kendall wrote:
>>> Update xfsrestore to use the new lpath_to_handle function
>>> when dealing with symlinks.
>>
>> Requiring a simultanously released version of xfsprogs is a very bad
>> idea.  The right fix is to add an autoconf check for the new function
>> and use it when available, falling back to the inferior old version
>> if it is not available.
>
> Good thought. However, there's also a run-time dependency since
> xfsrestore uses libhandle.so rather than the .a. I can rework something
> using dlsym - sound okay?

That's why the minor version of a shared library needs to get bumped
when adding a new symbol, see one of my replies to Alex.  Of course
symbol versioning would be even better, I'll see if I can port it from
acl/attr which use the same build system as xfsprogs.

<Prev in Thread] Current Thread [Next in Thread>