[Top] [All Lists]

Re: [PATCH 2/2] use lpath_to_handle when restoring symlinks

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/2] use lpath_to_handle when restoring symlinks
From: Bill Kendall <wkendall@xxxxxxx>
Date: Tue, 27 Oct 2009 10:36:04 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091025070544.GA21462@xxxxxxxxxxxxx>
References: <4AE08DD0.50304@xxxxxxx> <20091025070544.GA21462@xxxxxxxxxxxxx>
User-agent: Thunderbird (X11/20090817)
On 10/25/2009 02:05 AM, Christoph Hellwig wrote:
On Thu, Oct 22, 2009 at 11:52:32AM -0500, Bill Kendall wrote:
Update xfsrestore to use the new lpath_to_handle function
when dealing with symlinks.

Requiring a simultanously released version of xfsprogs is a very bad
idea.  The right fix is to add an autoconf check for the new function
and use it when available, falling back to the inferior old version
if it is not available.

Good thought. However, there's also a run-time dependency since
xfsrestore uses libhandle.so rather than the .a. I can rework something
using dlsym - sound okay?


<Prev in Thread] Current Thread [Next in Thread>