xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: simplify and unify source package generation

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: simplify and unify source package generation
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Mon, 26 Oct 2009 09:36:45 +1100 (EST)
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091025074715.GC9482@xxxxxxxxxxxxx>
----- "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:

> On Tue, Oct 13, 2009 at 10:49:51AM +1100, Nathan Scott wrote:
> > >From looking through the patch it seems OK to me.  I haven't had a
> chance
> > to test it out yet, though - but from just eyeballing it, and if
> noone
> > pipes up complaining about the auto-rpm-build removal (I don't
> expect
> > they will, at this stage of xfsprogs life) it all looks good and
> correct.
> 
> Thanks.  Does this count as a reviewed-by?

Yep, sorry - Reviewed-by: Nathan Scott <nathans@xxxxxxxxxx>

> Btw, one other thing I'm pondering is removing the automatic call to
> ./configure from make if it's not configured yet.  It causes lots of 
> pain for the toplevel makefile and the makefile snipplets in
> include/.
> We'd have to replace the .deb building makefile snipplet with a
> build-debs.sh shell script, but that might be cleaner anyway.

Its not so bad IMO & we seem to be getting into the realm of gratuitous
change, but - *shrug* - doesn't make much difference I guess, I'm sure
people will figure it out pretty quickly.

cheers.

-- 
Nathan

<Prev in Thread] Current Thread [Next in Thread>