----- "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:
> On Tue, Oct 13, 2009 at 10:49:51AM +1100, Nathan Scott wrote:
> > >From looking through the patch it seems OK to me. I haven't had a
> > to test it out yet, though - but from just eyeballing it, and if
> > pipes up complaining about the auto-rpm-build removal (I don't
> > they will, at this stage of xfsprogs life) it all looks good and
> Thanks. Does this count as a reviewed-by?
Yep, sorry - Reviewed-by: Nathan Scott <nathans@xxxxxxxxxx>
> Btw, one other thing I'm pondering is removing the automatic call to
> ./configure from make if it's not configured yet. It causes lots of
> pain for the toplevel makefile and the makefile snipplets in
> We'd have to replace the .deb building makefile snipplet with a
> build-debs.sh shell script, but that might be cleaner anyway.
Its not so bad IMO & we seem to be getting into the realm of gratuitous
change, but - *shrug* - doesn't make much difference I guess, I'm sure
people will figure it out pretty quickly.