xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: simplify and unify source package generation

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: simplify and unify source package generation
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 25 Oct 2009 03:47:15 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1205635767.11581255391391231.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <20091011024504.GA16725@xxxxxxxxxxxxx> <1205635767.11581255391391231.JavaMail.root@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Oct 13, 2009 at 10:49:51AM +1100, Nathan Scott wrote:
> >From looking through the patch it seems OK to me.  I haven't had a chance
> to test it out yet, though - but from just eyeballing it, and if noone
> pipes up complaining about the auto-rpm-build removal (I don't expect
> they will, at this stage of xfsprogs life) it all looks good and correct.

Thanks.  Does this count as a reviewed-by?

Btw, one other thing I'm pondering is removing the automatic call to
./configure from make if it's not configured yet.  It causes lots of 
pain for the toplevel makefile and the makefile snipplets in include/.
We'd have to replace the .deb building makefile snipplet with a
build-debs.sh shell script, but that might be cleaner anyway.

<Prev in Thread] Current Thread [Next in Thread>