xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix xfs_quota remove error

To: r-yamauchi@xxxxxxxxxxxxx
Subject: Re: [PATCH] xfs: fix xfs_quota remove error
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 22 Oct 2009 04:58:45 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091022160627r-yamauchi@xxxxxxxxxxxxxxx>
References: <20091022160627r-yamauchi@xxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Oct 22, 2009 at 04:06:27PM +0900, r-yamauchi@xxxxxxxxxxxxx wrote:
> Hi,
> 
> The xfs_quota returns ENOSYS when remove command is executed.
> My kernel version is 2.6.31 and xfsprogs version is 3.0.3.
> You can reproduce this issue with following steps.
> 
>     # mount -t xfs -o uquota /dev/sda7 /mnt/mp1
>     # xfs_quota -x -c off -c remove
>     XFS_QUOTARM: Function not implemented.
> 
> The remove command is allowed during quotaoff,
> but xfs_xstate() checks whether quota is running, 
> so it leads to ENOSYS.
> 
> To solve this problem, add conditional statement 
> that op is not X_QUOTARM with running check.

Thanks you, the patch looks correct.  I will write an xfstests testcase
based on your above report to make sure we can check for this regression
in the future.

<Prev in Thread] Current Thread [Next in Thread>