xfs
[Top] [All Lists]

Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 18 Oct 2009 23:54:26 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Patrick Schreurs <patrick@xxxxxxxxxxxxxxxx>, Tommy van Leeuwen <tommy@xxxxxxxxxxxxxxxx>, Bas Couwenberg <bas@xxxxxxxxxxxxxxxx>, XFS List <xfs@xxxxxxxxxxx>
In-reply-to: <20091019011600.GO9464@xxxxxxxxxxxxxxxx>
References: <20090930124104.GA7463@xxxxxxxxxxxxx> <4AC60D27.9060703@xxxxxxxxxxxxxxxx> <20091005214348.GA15448@xxxxxxxxxxxxx> <4ACB080D.3010708@xxxxxxxxxxxxxxxx> <20091007011926.GB32032@xxxxxxxxxxxxx> <4AD18C8D.90808@xxxxxxxxxxxxxxxx> <20091012233854.GA29446@xxxxxxxxxxxxx> <20091019011600.GO9464@xxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Mon, Oct 19, 2009 at 12:16:00PM +1100, Dave Chinner wrote:
> > +    * The hash lock here protects a thread in xfs_iget from racing with
> > +    * us on recycling the inode.  Once we have the XFS_IRECLAIM flag set
> > +    * it will not touch it.
> >      */
> > -   write_lock(&pag->pag_ici_lock);
> 
> Did you mean to remove this write_lock? The patch does not remove
> the unlocks....

It's taken by the caller.

<Prev in Thread] Current Thread [Next in Thread>