| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 04/14] repair: split up scanfunc_ino |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Tue, 13 Oct 2009 18:19:46 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| In-reply-to: | <4AD38C50.2060403@xxxxxxxxxxx> |
| References: | <20090902175531.469184575@xxxxxxxxxxxxxxxxxxxxxx> <20090902175840.403232401@xxxxxxxxxxxxxxxxxxxxxx> <4AD38C50.2060403@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Mon, Oct 12, 2009 at 03:06:40PM -0500, Eric Sandeen wrote: >> + agno, agbno, >> + mp->m_sb.sb_inopblock); > > pretty weird indentation here can't you just merge w/ previous line? XFS (especially userspace code) uses this in lots of places. Gives more space to messages but keeps the normal arguments normally aligned. > Also is the change from bno to agbno intentional in the message? > I guess it's fine. That version is more correct. Don't remember how it got in, though. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 03/14] repair: kill B_IS_META flag, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 04/14] repair: split up scanfunc_ino, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 04/14] repair: split up scanfunc_ino, Eric Sandeen |
| Next by Thread: | Re: [PATCH 04/14] repair: split up scanfunc_ino, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |