xfs
[Top] [All Lists]

Re: [PATCH] xfsprogs: simplify and unify source package generation

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: simplify and unify source package generation
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 12 Oct 2009 19:29:51 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1205635767.11581255391391231.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <1205635767.11581255391391231.JavaMail.root@xxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Nathan Scott wrote:
----- "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:

Currently the build/ directory can create rpm, debian and source /
binary
tar packages.  The RPM generation is not used as all distributions
prefer,
their own spec files, and the binary tarball not used at all as it's
a not very useful format.  Reimplement the generation of the source
tarballs to use the source-link method used for the debian packages
and
get rid of the whole old package generation machinery.  Also fix a
small
bug in the link-based source directory creation which was not
including
the .pot file for gettext.

From looking through the patch it seems OK to me.  I haven't had a chance
to test it out yet, though - but from just eyeballing it, and if noone
pipes up complaining about the auto-rpm-build removal (I don't expect
they will, at this stage of xfsprogs life) it all looks good and correct.

cheers.


die rpmbuild die ;)

Long as building tarballs works I'm happy.

-Eric

<Prev in Thread] Current Thread [Next in Thread>