[Top] [All Lists]

Re: [PATCH] xfsprogs: allow using libblkid instead of libdisk

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsprogs: allow using libblkid instead of libdisk
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 07 Oct 2009 13:52:47 -0500
Cc: xfs@xxxxxxxxxxx, util-linux-ng@xxxxxxxxxxxxxxx
In-reply-to: <20091006185252.GA10250@xxxxxxxxxxxxx>
References: <20091006185252.GA10250@xxxxxxxxxxxxx>
User-agent: Thunderbird (Macintosh/20090812)
Christoph Hellwig wrote:
Add a new --enable-blkid switch to use libblkid from util-linux to detect
the device geometry and check for existing partitions or filesystem on a
device.  Note that this requires the latest blkid from util-linux-ng git
for the topology calls, odler ones won't work.  If I had a little more
autoconf fu we might be able to detect a too early one, but right now it
just fails if it's too old and --enable-blkid is specified.

Here's some autoconf fu to check for blkid topo support; this changes it to
default to using blkid, optionally disable-able, and disables it automatically
if the topo stuff isn't found (I think ;)

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

diff --git a/configure.in b/configure.in
index 78ac522..f75fad1 100644
--- a/configure.in
+++ b/configure.in
@@ -35,11 +35,10 @@ AC_ARG_ENABLE(termcap,
        test $enable_termcap = yes && libtermcap="-ltermcap",)

+# AC_HAVE_BLKID_TOPO below wil find the library & check for topo support
-[ --enable-blkid=[yes/no] Enable block device id library [default=no]],
-       test $enable_blkid = yes && libblkid="-lblkid",)
+[ --enable-blkid=[yes/no] Enable block device id library [default=yes]],,
+       enable_blkid=yes)

[ --enable-lib64=[yes/no] Enable lib64 support [default=yes]],,
@@ -96,6 +95,7 @@ AC_HAVE_SENDFILE

diff --git a/m4/package_blkid.m4 b/m4/package_blkid.m4
new file mode 100644
index 0000000..44ca2cc
--- /dev/null
+++ b/m4/package_blkid.m4
@@ -0,0 +1,20 @@
+# See if blkid has the topology bits
+  enable_blkid="$1"
+  if test "$enable_blkid" = "yes"; then
+    AC_SEARCH_LIBS([blkid_probe_all], [blkid])
+    AC_CHECK_FUNCS(blkid_probe_get_topology)
+    if test $ac_cv_func_blkid_probe_get_topology = yes; then
+      libblkid="-lblkid"
+    else
+      libblkd=""
+      enable_blkid="no"
+      AC_SUBST(enable_blkid)
+    fi
+  fi
+  AC_SUBST(libblkid)

<Prev in Thread] Current Thread [Next in Thread>