| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] mkfs: add discard support |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 7 Oct 2009 15:42:16 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20091006184758.GA4780@xxxxxxxxxxxxx> |
| References: | <20091006184758.GA4780@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Tue, Oct 06, 2009 at 02:47:58PM -0400, Christoph Hellwig wrote: > Call the BLKDISCARD ioctl to mark the whole disk as unused before creating > a new filesystem. This will allow SSDs, Arrays with thin provisioning support > and virtual machines to make smarter allocation decisions. Good idea, but perhaps the discard should be optional rather than unconditional. My immediate thought was the SOP for setting up encrypted devices - fill the empty disk with random data before setting up the encrypted device. If you then send it a discard.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] mkfs: add discard support, Eric Sandeen |
|---|---|
| Next by Date: | [PATCH 0/8] Add vsprintf extension %pU to print UUID/GUIDs and use it, Joe Perches |
| Previous by Thread: | [PATCH] mkfs: add discard support, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] mkfs: add discard support, Michael Monnerie |
| Indexes: | [Date] [Thread] [Top] [All Lists] |