xfs
[Top] [All Lists]

Re: [PATCH] mkfs: add discard support

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH] mkfs: add discard support
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 06 Oct 2009 22:55:48 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1157959921.9631254878431584.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <1157959921.9631254878431584.JavaMail.root@xxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Nathan Scott wrote:
----- "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:

It might be a bit cleaner to add this in with the existing
platform-
specific code in libxfs/linux.c (or perhaps
include/platform_defs.h)
with wrappers for the other platforms, rather than putting it
directly
in mkfs like this?  repair may want to use this someday too, I
guess.

How about this one?


Looks good to me.

cheers.


looks good to me too, thanks.

need to get that vertex flashed w/ trim support some day...

-eric

<Prev in Thread] Current Thread [Next in Thread>