Re: [PATCH] mkfs: add discard support

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Nathan Scott wrote:
> ----- "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:
>
> > > It might be a bit cleaner to add this in with the existing
> > platform-
> > > specific code in libxfs/linux.c (or perhaps
> > include/platform_defs.h)
> > > with wrappers for the other platforms, rather than putting it
> > directly
> > > in mkfs like this?  repair may want to use this someday too, I
> > guess.
> >
> > How about this one?
> Looks good to me.
>
> cheers.
looks good to me too, thanks.

need to get that vertex flashed w/ trim support some day...

-eric