[Top] [All Lists]

Re: [PATCH] mkfs: add discard support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] mkfs: add discard support
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Wed, 7 Oct 2009 12:20:31 +1100 (EST)
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20091007011850.GA32032@xxxxxxxxxxxxx>
----- "Christoph Hellwig" <hch@xxxxxxxxxxxxx> wrote:

> > It might be a bit cleaner to add this in with the existing
> platform-
> > specific code in libxfs/linux.c (or perhaps
> include/platform_defs.h)
> > with wrappers for the other platforms, rather than putting it
> directly
> > in mkfs like this?  repair may want to use this someday too, I
> guess.
> How about this one?

Looks good to me.



<Prev in Thread] Current Thread [Next in Thread>