[Top] [All Lists]

Re: [PATCH] mkfs: add discard support

To: Nathan Scott <nscott@xxxxxxxxxx>
Subject: Re: [PATCH] mkfs: add discard support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 6 Oct 2009 15:26:46 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <837780486.21741254857073773.JavaMail.root@xxxxxxxxxxxxxxxxxx>
References: <1235789111.21721254856913943.JavaMail.root@xxxxxxxxxxxxxxxxxx> <837780486.21741254857073773.JavaMail.root@xxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Oct 07, 2009 at 06:24:33AM +1100, Nathan Scott wrote:
> It might be a bit cleaner to add this in with the existing platform-
> specific code in libxfs/linux.c (or perhaps include/platform_defs.h)
> with wrappers for the other platforms, rather than putting it directly
> in mkfs like this?  repair may want to use this someday too, I guess.

Yeah, that might be better. 

<Prev in Thread] Current Thread [Next in Thread>