| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: enable generic filesystems on some ENOSPC tests |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 30 Sep 2009 08:43:55 -0400 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx> |
| In-reply-to: | <4AC1114C.2070802@xxxxxxxxxx> |
| References: | <4AC1114C.2070802@xxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
The change to 204 and the infrastructure seems fine for me, but I don't really like how the other use an explicit agcount (which at least for 109 was very intentional) for xfs and just defaults for others. At least 109 should be duplicated into a generic one run everywhere and an xfs-specific with the agcount. Need to look a bit more at the history of 083 to max a decision for that one. And some less cryptic variable names in the new code would also be nice. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: 2.6.31 xfs_fs_destroy_inode: cannot reclaim, Christoph Hellwig |
|---|---|
| Next by Date: | Extended attribute caching questions, Richard |
| Previous by Thread: | [PATCH] xfstests: enable generic filesystems on some ENOSPC tests, Eric Sandeen |
| Next by Thread: | xfsprogs German translation, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |