xfs
[Top] [All Lists]

Re: [PATCH V2] xfs_repair: fix record_allocation list manipulation

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfs_repair: fix record_allocation list manipulation
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 22 Sep 2009 16:04:56 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4AB8EB80.80707@xxxxxxxxxxx>
References: <4AB300CC.5020707@xxxxxxxxxxx> <4AB4EDBC.9050609@xxxxxxxxxxx> <20090922120231.GB8143@xxxxxxxxxxxxx> <4AB8EB80.80707@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Sep 22, 2009 at 10:21:36AM -0500, Eric Sandeen wrote:
> > After reviewing it again I noticed that it can actually work 
> 
> the original code can work?

Well, could in theory if fixed as in your patch ;-)

> IF barry's speedups stuff obsoletes this work should I just put it on
> the shelf for now?

No, it doesn't.  As I mentioned his original patches contained a fix
like yours, but I left it out because I didn't understand it yet.

I think the patch will cause some minor merge pain as it touches
incore.c which gets more or less fully rewritten as part of the
patch series.  I think it's useful enough to be put in, but so are
the other repair patches :)

<Prev in Thread] Current Thread [Next in Thread>