Re: [PATCH] xfs_fsr: fix test for short write

xfs

Re: [PATCH] xfs_fsr: fix test for short write

To:	Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject:	Re: [PATCH] xfs_fsr: fix test for short write
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Tue, 22 Sep 2009 08:03:53 -0400
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to:	<4AB307AD.9010904@xxxxxxxxxxx>
References:	<4AB307AD.9010904@xxxxxxxxxxx>
User-agent:	Mutt/1.5.19 (2009-01-05)

On Thu, Sep 17, 2009 at 11:08:13PM -0500, Eric Sandeen wrote:
> Clang found this one too, as a dead nested assignment.
>
> The point is to see if we write all the bytes; but the initial
> assignment is backwards.  It's safe in the end, because if they
> weren't already equal anyway, we'd have exited prior to this, but
> it's worth fixing up for clarity.
>
> Signed-of-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Looks good to me, 


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] xfs_fsr: fix test for short write, Eric Sandeen Re: [PATCH] xfs_fsr: fix test for short write, Christoph Hellwig <=

Previous by Date:	Re: [PATCH V2] xfs_repair: fix record_allocation list manipulation, Christoph Hellwig
Next by Date:	Re: [patch] xfsprogs build tweaks for Debian, Christoph Hellwig
Previous by Thread:	[PATCH] xfs_fsr: fix test for short write, Eric Sandeen
Next by Thread:	Question about your Website, Joy Ford
Indexes:	[Date] [Thread] [Top] [All Lists]