xfs
[Top] [All Lists]

Re: [PATCH] xfs_fsr: fix test for short write

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_fsr: fix test for short write
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 22 Sep 2009 08:03:53 -0400
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4AB307AD.9010904@xxxxxxxxxxx>
References: <4AB307AD.9010904@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Sep 17, 2009 at 11:08:13PM -0500, Eric Sandeen wrote:
> Clang found this one too, as a dead nested assignment.
>
> The point is to see if we write all the bytes; but the initial
> assignment is backwards.  It's safe in the end, because if they
> weren't already equal anyway, we'd have exited prior to this, but
> it's worth fixing up for clarity.
>
> Signed-of-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Looks good to me, 


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>