Eric Sandeen wrote:
clang found this one too as a "Dead assignment"
Unless my pointer-fu is totally messed up, this function
was never actually updating the list head.
This would mean that the later free_allocations() calls in
incore_ext_teardown() and free_rt_dup_extent_tree() don't
actually free more than one item, and therefore leak memory.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
diff --git a/repair/incore.c b/repair/incore.c
index 84626c9..77f4630 100644
@@ -33,7 +33,7 @@ void
record_allocation(ba_rec_t *addr, ba_rec_t *list)
addr->next = list;
- list = addr;
+ *list = addr;
argh that's not right, I swear I built it, oops.
Will send an update later.
xfs mailing list