xfs
[Top] [All Lists]

Re: [PATCH] xfs_repair: fix record_allocation list manipulation

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs_repair: fix record_allocation list manipulation
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 17 Sep 2009 23:54:59 -0500
In-reply-to: <4AB300CC.5020707@xxxxxxxxxxx>
References: <4AB300CC.5020707@xxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Eric Sandeen wrote:
clang found this one too as a "Dead assignment"

Unless my pointer-fu is totally messed up, this function
was never actually updating the list head.

This would mean that the later free_allocations() calls in
incore_ext_teardown() and free_rt_dup_extent_tree() don't
actually free more than one item, and therefore leak memory.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
---

clang record:
http://sandeen.net/clang/xfsprogs/2009-09-09-1/report-1Jnl15.html#EndPath

diff --git a/repair/incore.c b/repair/incore.c
index 84626c9..77f4630 100644
--- a/repair/incore.c
+++ b/repair/incore.c
@@ -33,7 +33,7 @@ void
record_allocation(ba_rec_t *addr, ba_rec_t *list)
{
    addr->next = list;
-    list = addr;
+    *list = addr;

argh that's not right, I swear I built it, oops.

Will send an update later.


    return;
}

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


<Prev in Thread] Current Thread [Next in Thread>