xfs
[Top] [All Lists]

Re: xfsprogs: remove unused scripts

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfsprogs: remove unused scripts
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 09 Sep 2009 12:23:26 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090902174407.GA9759@xxxxxxxxxxxxx>
References: <20090902174407.GA9759@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Christoph Hellwig wrote:
xfs_check64.sh and xfs_ncheck64.sh are outdated copies of xfs_check.sh
and xfs_ncheck.sh which call a non-existant xfs_db64 binary.  They
are never installed or otherwise used, so remove them.   They are
probably a leftover from IRIX

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

OK with me, as long as sgi doesn't still have some secret xfs_db64 actually in use somewhere today that they still care about.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Index: xfsprogs-dev/db/Makefile
===================================================================
--- xfsprogs-dev.orig/db/Makefile       2009-09-02 14:35:19.413268749 -0300
+++ xfsprogs-dev/db/Makefile    2009-09-02 14:35:29.081614935 -0300
@@ -15,7 +15,6 @@ HFILES = addr.h agf.h agfl.h agi.h attr.
        text.h type.h write.h attrset.h
 CFILES = $(HFILES:.h=.c)
 LSRCFILES = xfs_admin.sh xfs_check.sh xfs_ncheck.sh xfs_metadump.sh
-LSRCFILES += xfs_check64.sh xfs_ncheck64.sh
LLDLIBS = $(LIBXFS) $(LIBXLOG) $(LIBUUID) $(LIBRT) $(LIBPTHREAD)
 LTDEPENDENCIES = $(LIBXFS) $(LIBXLOG)
Index: xfsprogs-dev/db/xfs_check64.sh
===================================================================
--- xfsprogs-dev.orig/db/xfs_check64.sh 2009-09-02 14:35:39.477268924 -0300
+++ /dev/null   1970-01-01 00:00:00.000000000 +0000
@@ -1,36 +0,0 @@
-#!/bin/sh -f
-#
-# Copyright (c) 2000-2003 Silicon Graphics, Inc.  All Rights Reserved.
-#
-
-OPTS=" "
-DBOPTS=" "
-USAGE="Usage: xfs_check64 [-fsvV] [-l logdev] [-i ino]... [-b bno]... special"
-
-while getopts "b:fi:l:stvV" c
-do
-       case $c in
-       s)      OPTS=$OPTS"-s ";;
-       t)      OPTS=$OPTS"-t ";;
-       v)      OPTS=$OPTS"-v ";;
-       V)      OPTS=$OPTS"-V ";;
-       i)      OPTS=$OPTS"-i "$OPTARG" ";;
-       b)      OPTS=$OPTS"-b "$OPTARG" ";;
-       f)      DBOPTS=" -f";;
-       l)      DBOPTS=$DBOPTS" -l "$OPTARG" ";;
-       \?)     echo $USAGE 1>&2
-               exit 2
-               ;;
-       esac
-done
-set -- extra $@
-shift $OPTIND
-case $# in
-       1)      xfs_db64$DBOPTS -F -i -p xfs_check64 -c "check$OPTS" $1
-               status=$?
-               ;;
-       *)      echo $USAGE 1>&2
-               exit 2
-               ;;
-esac
-exit $status
Index: xfsprogs-dev/db/xfs_ncheck64.sh
===================================================================
--- xfsprogs-dev.orig/db/xfs_ncheck64.sh        2009-09-02 14:35:33.717268763 
-0300
+++ /dev/null   1970-01-01 00:00:00.000000000 +0000
@@ -1,34 +0,0 @@
-#!/bin/sh -f
-#
-# Copyright (c) 2000-2001 Silicon Graphics, Inc.  All Rights Reserved.
-#
-
-OPTS=" "
-DBOPTS=" "
-USAGE="usage: xfs_ncheck64 [-sfvV] [-l logdev] [-i ino]... special"
-
-while getopts "b:fi:l:svV" c
-do
-       case $c in
-       s)      OPTS=$OPTS"-s ";;
-       i)      OPTS=$OPTS"-i "$OPTARG" ";;
-       v)      OPTS=$OPTS"-v ";;
-       V)      OPTS=$OPTS"-V ";;
-       f)      DBOPTS=" -f";;
-       l)      DBOPTS=$DBOPTS" -l "$OPTARG" ";;
-       \?)     echo $USAGE 1>&2
-               exit 2
-               ;;
-       esac
-done
-set -- extra $@
-shift $OPTIND
-case $# in
-       1)      xfs_db64$DBOPTS -r -p xfs_ncheck64 -c "blockget -ns" -c 
"ncheck$OPTS" $1
-               status=$?
-               ;;
-       *)      echo $USAGE 1>&2
-               exit 2
-               ;;
-esac
-exit $status

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


<Prev in Thread] Current Thread [Next in Thread>