xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v2.6.30-rc4-

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v2.6.30-rc4-12478-g4564c56
From: xfs@xxxxxxxxxxx
Date: Wed, 9 Sep 2009 11:59:26 -0500
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  4564c56 xfs: use correct log reservation when handling ENOSPC in xfs_create
  988abe4 xfs: xfs_showargs() reports group *and* project quotas enabled
      from  81e251766e8f8c9d7abb5db784e58c5c45f82797 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4564c56521659850db1af36bada9d26a712cd473
Author: xfs-bounces@xxxxxxxxxxx <xfs-bounces@xxxxxxxxxxx>
Date:   Wed Sep 9 09:23:52 2009 -0500

    xfs: use correct log reservation when handling ENOSPC in xfs_create
    
    We added the ENOSPC handling patch in xfs_create just after it got
    merged with xfs_mkdir.  Change the log reservation to the variable for
    either the create or mkdir value so it does the right thing if get
    here for creating a directory.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Alex Elder <aelder@xxxxxxx>
    Signed-off-by: Alex Elder <aelder@xxxxxxx>

commit 988abe4075e5748d9f7c79d9dfffa0cf5291611b
Author: Alex Elder <aelder@xxxxxxx>
Date:   Wed Sep 2 17:02:24 2009 -0500

    xfs: xfs_showargs() reports group *and* project quotas enabled
    
    If you enable group or project quotas on an XFS file system, then the
    mount table presented through /proc/self/mounts erroneously shows
    that both options are in effect for the file system.  The root of
    the problem is some bad logic in the xfs_showargs() function, which
    is used to format the file system type-specific options in effect
    for a file system.
    
    The problem originated in this GIT commit:
        Move platform specific mount option parse out of core XFS code
        Date: 11/22/07
        Author: Dave Chinner
        SHA1 ID: a67d7c5f5d25d0b13a4dfb182697135b014fa478
    
    For XFS quotas, project and group quota management are mutually
    exclusive--only one can be in effect at a time.  There are two
    parts to managing quotas:  aggregating usage information; and
    enforcing limits.  It is possible to have a quota in effect
    (aggregating usage) but not enforced.
    
    These features are recorded on an XFS mount point using these flags:
        XFS_PQUOTA_ACCT - Project quotas are aggregated
        XFS_GQUOTA_ACCT - Group quotas are aggregated
        XFS_OQUOTA_ENFD - Project/group quotas are enforced
    
    The code in error is in fs/xfs/linux-2.6/xfs_super.c:
    
            if (mp->m_qflags & (XFS_PQUOTA_ACCT|XFS_OQUOTA_ENFD))
                    seq_puts(m, "," MNTOPT_PRJQUOTA);
            else if (mp->m_qflags & XFS_PQUOTA_ACCT)
                    seq_puts(m, "," MNTOPT_PQUOTANOENF);
    
            if (mp->m_qflags & (XFS_GQUOTA_ACCT|XFS_OQUOTA_ENFD))
                    seq_puts(m, "," MNTOPT_GRPQUOTA);
            else if (mp->m_qflags & XFS_GQUOTA_ACCT)
                    seq_puts(m, "," MNTOPT_GQUOTANOENF);
    
    The problem is that XFS_OQUOTA_ENFD will be set in mp->m_qflags
    if either group or project quotas are enforced, and as a result
    both MNTOPT_PRJQUOTA and MNTOPT_GRPQUOTA will be shown as mount
    options.
    
    Signed-off-by: Alex Elder <aelder@xxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Felix Blyakher <felixb@xxxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/linux-2.6/xfs_super.c |   22 +++++++++++++---------
 fs/xfs/xfs_vnodeops.c        |    4 ++--
 2 files changed, 15 insertions(+), 11 deletions(-)


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v2.6.30-rc4-12478-g4564c56, xfs <=