[Top] [All Lists]

Re: [PATCH] xfs: un-static xfs_inobt_lookup

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: un-static xfs_inobt_lookup
From: Felix Blyakher <felixb@xxxxxxx>
Date: Tue, 1 Sep 2009 20:37:56 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090901235655.GA15321@xxxxxxxxxxxxx>
References: <20090901235655.GA15321@xxxxxxxxxxxxx>

On Sep 1, 2009, at 6:56 PM, Christoph Hellwig wrote:

xfs_inobt_lookup is also used in xfs_itable.c, remove the STATIC modifier
from it's declaration to fix non-debug builds.

Argh! I think, this or similar thing bit us once in past.

This was already fixed in my git tree vs the version last posted to the

Applying it quickly to the oss as well.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Felix Blyakher <felixb@xxxxxxx>

Index: xfs/fs/xfs/xfs_ialloc.c
--- xfs.orig/fs/xfs/xfs_ialloc.c        2009-09-01 20:47:28.515468366 -0300
+++ xfs/fs/xfs/xfs_ialloc.c     2009-09-01 20:47:33.867913011 -0300
@@ -59,7 +59,7 @@ xfs_ialloc_cluster_alignment(
 * Lookup a record by ino in the btree given by cur.
-STATIC int                             /* error */
+int                                    /* error */
        struct xfs_btree_cur    *cur,   /* btree cursor */
        xfs_agino_t             ino,    /* starting inode of chunk */

xfs mailing list

<Prev in Thread] Current Thread [Next in Thread>