xfs
[Top] [All Lists]

Re: xfs compat_ioctl?

To: Torsten Kaiser <just.for.lkml@xxxxxxxxxxxxxx>
Subject: Re: xfs compat_ioctl?
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 01 Sep 2009 12:55:23 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Michael Tokarev <mjt@xxxxxxxxxx>, Linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <64bb37e0909011000l78a0aef0wf4c53252c14af75e@xxxxxxxxxxxxxx>
References: <4A9B759B.7020401@xxxxxxxxxxxxxxxx> <20090831123010.GA2368@xxxxxxxxxxxxx> <64bb37e0908311114t4a3cefc3v8ea5092e1558c578@xxxxxxxxxxxxxx> <20090831182754.GA3620@xxxxxxxxxxxxx> <64bb37e0909011000l78a0aef0wf4c53252c14af75e@xxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.21 (X11/20090320)
Torsten Kaiser wrote:
> On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@xxxxxxxxxxxxx> wrote:
>> I think you are right, the constant used is incorrect.  Does the small
>> patch below fix it for you?
> 
> Yes, after adding this patch, xfs_fsr works.

Crud, sorry about that.  I swear I ran 32-bit xfstests under a 64-bit
kernel, but I think we were lacking in fsr coverage....

-Eric

>> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
>> ===================================================================
>> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c       2009-08-31 
>> 15:25:06.093044591 -0300
>> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c    2009-08-31 
>> 15:25:10.856544216 -0300
>> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
>>        case XFS_IOC_GETVERSION_32:
>>                cmd = _NATIVE_IOC(cmd, long);
>>                return xfs_file_ioctl(filp, cmd, p);
>> -       case XFS_IOC_SWAPEXT: {
>> +       case XFS_IOC_SWAPEXT_32: {
>>                struct xfs_swapext        sxp;
>>                struct compat_xfs_swapext __user *sxu = arg;
>>
>>
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>