[Top] [All Lists]

Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function
From: Theodore Tso <tytso@xxxxxxx>
Date: Wed, 26 Aug 2009 22:05:33 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090826221201.GC18119@xxxxxxxxxxxxx>
References: <1250607467-15085-1-git-send-email-tytso@xxxxxxx> <20090818161116.GA2162@xxxxxxxxxxxxx> <20090818170456.GF28560@xxxxxxx> <20090826221201.GC18119@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Aug 26, 2009 at 06:12:01PM -0400, Christoph Hellwig wrote:
> On Tue, Aug 18, 2009 at 01:04:56PM -0400, Theodore Tso wrote:
> > > Looks like the only difference between the generic and the extN
> > > check routine is the addition of -f to the fsck command line.  What
> > > about just introducing a _fsck_args similar to _mount_opts where
> > > filesystems can set their additional required mount options?
> > 
> > That would work, yeah, and would be result in far less code
> > duplication in common.rc.  I'll take a whack at it and resubmit.
> Are you still going to look at it realtively soon?  If not I'll just
> put this version in to imrove the test coverage on extN and we can
> clean it up later.

Sorry, work has gotten busy and I'm trying to get some last patches
whipped into shape before the merge window opens.  I probably won't
have time to look at this for at least a week or two.  So if you want
to merge this version in for now, I'll try to clean it up when I have
a chance.

                                 - Ted

<Prev in Thread] Current Thread [Next in Thread>