xfs
[Top] [All Lists]

Re: [PATCH] xfs_io: actually issue 0 size writes

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs_io: actually issue 0 size writes
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 26 Aug 2009 16:26:25 -0700
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <20090826221106.GB18119@xxxxxxxxxxxxx>
References: <4A849096.1010600@xxxxxxxxxxx> <20090826221106.GB18119@xxxxxxxxxxxxx>
On Aug 26, 2009, at 3:11 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

On Thu, Aug 13, 2009 at 05:15:50PM -0500, Eric Sandeen wrote:
While testing some stuff in generic_write_checks() in the
kernel I realized that you can't actually use xfs_io to send
a 0-byte write in.  This is actually a condition worth testing:

      If  count  is zero and fd refers to a regular file,
      then write() may return a failure status if one  of
      the  errors  below  is  detected.  If no errors are
      detected, 0 will be returned  without  causing  any
      other  effect.

So fix that up.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Any reason you didn't put this in despite two positive reviews?

Just general busyness and a vacation :)

Will do it soon.

-Eric

<Prev in Thread] Current Thread [Next in Thread>