xfs
[Top] [All Lists]

Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function

To: Theodore Tso <tytso@xxxxxxx>
Subject: Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 26 Aug 2009 18:12:01 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20090818170456.GF28560@xxxxxxx>
References: <1250607467-15085-1-git-send-email-tytso@xxxxxxx> <20090818161116.GA2162@xxxxxxxxxxxxx> <20090818170456.GF28560@xxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Tue, Aug 18, 2009 at 01:04:56PM -0400, Theodore Tso wrote:
> > Looks like the only difference between the generic and the extN
> > check routine is the addition of -f to the fsck command line.  What
> > about just introducing a _fsck_args similar to _mount_opts where
> > filesystems can set their additional required mount options?
> 
> That would work, yeah, and would be result in far less code
> duplication in common.rc.  I'll take a whack at it and resubmit.

Are you still going to look at it realtively soon?  If not I'll just
put this version in to imrove the test coverage on extN and we can
clean it up later.

<Prev in Thread] Current Thread [Next in Thread>