| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_io: actually issue 0 size writes |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 26 Aug 2009 18:11:06 -0400 |
| Cc: | xfs mailing list <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4A849096.1010600@xxxxxxxxxxx> |
| References: | <4A849096.1010600@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.19 (2009-01-05) |
On Thu, Aug 13, 2009 at 05:15:50PM -0500, Eric Sandeen wrote: > While testing some stuff in generic_write_checks() in the > kernel I realized that you can't actually use xfs_io to send > a 0-byte write in. This is actually a condition worth testing: > > If count is zero and fd refers to a regular file, > then write() may return a failure status if one of > the errors below is detected. If no errors are > detected, 0 will be returned without causing any > other effect. > > So fix that up. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> Any reason you didn't put this in despite two positive reviews? |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] xfstests: fix 192 for external logs and enable it by default, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] Add ext2/3/4-specific _check_extN_filesystem function, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH] xfs_io: actually issue 0 size writes, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfs_io: actually issue 0 size writes, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |