> From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
> Sent: Tuesday, August 25, 2009 1:57 PM
> To: Alex Elder
> Cc: Christoph Hellwig; xfs@xxxxxxxxxxx
> Subject: Re: [PATCH 0/7] inode allocation cleanups
> On Tue, Aug 25, 2009 at 12:57:16PM -0500, Alex Elder wrote:
> > # [PATCH 5/7] xfs: untangle xfs_dialloc Christoph Hellwig
> > No cursor cleanup on WANT_CORRUPTED_RETURN() just after
> "if (pagno == agno)".
> > (Maybe I'm misreading the patch.) I realize this is
> still better than the
> > ASSERT() in place currently, but maybe it should be
> > instead.
> Good catch, the two in xfs_dialloc should indeed be
> For the one in xfs_ialloc_next_rec.
> Below is the updated version of the patch, still needs to run through
> XFSQA again:
. . .
I did not review this one as carefully, but I see that you changed
those two spots to WANT_CORRUPTED_GOTO() calls and I assume that's
all that's really changed.