xfs
[Top] [All Lists]

Re: [PATCH 13/17] xfs: Convert sync_page_range() to simple fdatawrite_ra

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 13/17] xfs: Convert sync_page_range() to simple fdatawrite_range()
From: Jan Kara <jack@xxxxxxx>
Date: Fri, 21 Aug 2009 19:59:43 +0200
Cc: Jan Kara <jack@xxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, Felix Blyakher <felixb@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20090821172801.GA30254@xxxxxx>
References: <1250875447-15622-1-git-send-email-jack@xxxxxxx> <1250875447-15622-14-git-send-email-jack@xxxxxxx> <20090821172801.GA30254@xxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Fri 21-08-09 19:28:01, Christoph Hellwig wrote:
> On Fri, Aug 21, 2009 at 07:24:03PM +0200, Jan Kara wrote:
> > +           error2 = filemap_fdatawrite_range(mapping, pos, pos + ret - 1);
> 
> I think this should be a filemap_write_and_wait_range
  Ah true, I somehow misinterpretted what xfs_write_sync_logforce() does.

                                                                        Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR

<Prev in Thread] Current Thread [Next in Thread>