[Top] [All Lists]

Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing t

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 07/17] vfs: Introduce new helpers for syncing after writing to O_SYNC file or IS_SYNC inode
From: Jan Kara <jack@xxxxxxx>
Date: Fri, 21 Aug 2009 17:48:29 +0200
Cc: Jan Kara <jack@xxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Evgeniy Polyakov <zbr@xxxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, Joel Becker <joel.becker@xxxxxxxxxx>, Felix Blyakher <felixb@xxxxxxx>, xfs@xxxxxxxxxxx, Anton Altaparmakov <aia21@xxxxxxxxxx>, linux-ntfs-dev@xxxxxxxxxxxxxxxxxxxxx, OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>, linux-ext4@xxxxxxxxxxxxxxx, tytso@xxxxxxx
In-reply-to: <20090821153235.GA5874@xxxxxxxxxxxxx>
References: <1250697884-22288-1-git-send-email-jack@xxxxxxx> <1250697884-22288-8-git-send-email-jack@xxxxxxx> <20090819162638.GE6150@xxxxxxxxxxxxx> <20090820121531.GC16486@xxxxxxxxxxxxxxx> <20090820162729.GA24659@xxxxxxxxxxxxx> <20090821152339.GD3007@xxxxxxxxxxxxxxx> <20090821153235.GA5874@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Fri 21-08-09 11:32:35, Christoph Hellwig wrote:
> On Fri, Aug 21, 2009 at 05:23:39PM +0200, Jan Kara wrote:
> >   Hmm, I can imagine it would buy us something in two cases (but looking at
> > the code, neither is implemented in such a way that it would really help
> > us in any way):
> > 1) when an inode and it's data are stored in one block (e.g. OCFS2 or UDF) 
> > do
> >    this.
> >   In the first case we would wait for block with data to be written only to
> > submit it again because inode was still dirty.
> But we would not actually store in the pagecache or at least never
> writeback it via the pacache in that case, but always just write it as
> part of the inode.
  Yes, probably. Actually, that's what UDF does. It's just that then the
sequence fdatawrite(), fdatawait() does not really send the data to disk.
But that probably does not matter.

Jan Kara <jack@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>