xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs: batched discard support

To: Mark Lord <liml@xxxxxx>
Subject: Re: [PATCH, RFC] xfs: batched discard support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 16 Aug 2009 09:53:15 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, jens.axboe@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <4A8802F3.6010908@xxxxxx>
References: <20090816004705.GA7347@xxxxxxxxxxxxx> <4A876255.10606@xxxxxx> <4A876CA9.20906@xxxxxx> <20090816022500.GA12392@xxxxxxxxxxxxx> <4A8802F3.6010908@xxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sun, Aug 16, 2009 at 09:00:35AM -0400, Mark Lord wrote:
> Okay, this gives me ENOSYS now --> discard/trim support is missing from
> the lower layers.

ENOSYS or EOPNOTSUPP?

> What other patches do I need to make this work?
>
> The latest from Matthew's discard tree (May 2009) don't appear to be 
> sufficient,
> even after updating them for 2.6.31-rc6.

Hmm.  That was kinda the reason why I didn't want to post stuff yet.  In
current mainline only MTD implements the prepare_discard_fn, and we'll
need it implemented and working.  I think Matthews patches should be
sufficient, unless they have some ATA revision check to not issue the
TRIM for your device.

<Prev in Thread] Current Thread [Next in Thread>