xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs: batched discard support

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfs: batched discard support
From: Mark Lord <liml@xxxxxx>
Date: Sun, 16 Aug 2009 09:00:35 -0400
Cc: xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jens.axboe@xxxxxxxxxx
In-reply-to: <20090816022500.GA12392@xxxxxxxxxxxxx>
Organization: Real-Time Remedies Inc.
References: <20090816004705.GA7347@xxxxxxxxxxxxx> <4A876255.10606@xxxxxx> <4A876CA9.20906@xxxxxx> <20090816022500.GA12392@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.22 (X11/20090608)
Christoph Hellwig wrote:
On Sat, Aug 15, 2009 at 10:19:21PM -0400, Mark Lord wrote:
Mark Lord wrote:
Christoph Hellwig wrote:
..
Mark, any chance to try it?  Just create an XFS filesystem, age it a
bit and then call the attached little trim.c program on the mountmoint
(or any file inside the filesystem for that matter)
..

Looking at it now.  Thanks, Christoph!
..

Fails to work on 64-bit kernel w/ 32-bit userspace (no compat ioctl).
Rebuilding with 32-bit kernel now..

The actual ioctl is compatible, just add the

        case XFS_IOC_TRIM:
                return xfs_ioc_trim(mp, arg);

to xfs_file_compat_ioctl().  I'll add this to the next spin of the patch.
..

Okay, this gives me ENOSYS now --> discard/trim support is missing from
the lower layers.

What other patches do I need to make this work?

The latest from Matthew's discard tree (May 2009) don't appear to be sufficient,
even after updating them for 2.6.31-rc6.

???

<Prev in Thread] Current Thread [Next in Thread>