xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs: batched discard support

To: Mark Lord <liml@xxxxxx>
Subject: Re: [PATCH, RFC] xfs: batched discard support
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 15 Aug 2009 22:25:00 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, jens.axboe@xxxxxxxxxx
In-reply-to: <4A876CA9.20906@xxxxxx>
References: <20090816004705.GA7347@xxxxxxxxxxxxx> <4A876255.10606@xxxxxx> <4A876CA9.20906@xxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Sat, Aug 15, 2009 at 10:19:21PM -0400, Mark Lord wrote:
> Mark Lord wrote:
>> Christoph Hellwig wrote:
> ..
>>> Mark, any chance to try it?  Just create an XFS filesystem, age it a
>>> bit and then call the attached little trim.c program on the mountmoint
>>> (or any file inside the filesystem for that matter)
>> ..
>>
>> Looking at it now.  Thanks, Christoph!
> ..
>
> Fails to work on 64-bit kernel w/ 32-bit userspace (no compat ioctl).
> Rebuilding with 32-bit kernel now..

The actual ioctl is compatible, just add the

        case XFS_IOC_TRIM:
                return xfs_ioc_trim(mp, arg);

to xfs_file_compat_ioctl().  I'll add this to the next spin of the
patch.

<Prev in Thread] Current Thread [Next in Thread>