xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests 218: very basic defragmentation testing for xfs

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests 218: very basic defragmentation testing for xfs & ext4
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2009 10:09:30 -0400
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, ext4 development <linux-ext4@xxxxxxxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4A7A5CA8.8040702@xxxxxxxxxxx>
References: <4A5E3A37.5050306@xxxxxxxxxx> <4A7A5CA8.8040702@xxxxxxxxxxx>
User-agent: Mutt/1.5.19 (2009-01-05)
On Wed, Aug 05, 2009 at 11:31:36PM -0500, Eric Sandeen wrote:
> Test a few very basic defragmentation scenarios.
> 
> This test creates some files, runs defrag on them,
> and compares the before/after fragmentation as well
> as file md5sums and timestamps.
> 
> The test currently expects to find e4defrag in
> /usr/bin
> 
> It should be relatively easy to add more interestingly
> fragmented files to the tests, as well as to test
> that memory-mapped files aren't touched, etc - 
> but this gives us a framework.
> 
> V2: remount before checking file contents, and create
> common.defrag.

The patch loks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Unfortunately it still fails on my Debian testing system with:

 QA output created by 218
 zero-length file:
-Before: 0
-After: 0
+Before: 1
+After: 1
 Sparse file (no blocks):
-Before: 0
-After: 0
+Before: 1
+After: 1

But that's due to a bug in filefrag that I have already reported to the
Debian BTS.

<Prev in Thread] Current Thread [Next in Thread>